Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Windows tests can pass with errors #551

Closed
jaimergp opened this issue Aug 15, 2022 · 0 comments · Fixed by #553
Closed

[CI] Windows tests can pass with errors #551

jaimergp opened this issue Aug 15, 2022 · 0 comments · Fixed by #553
Labels
locked [bot] locked due to inactivity

Comments

@jaimergp
Copy link
Contributor

The /S (silent) mode of NSIS does not really error out if something goes wrong. So we won't catch errors at install time, only at build time. It doesn't really produce any logs directly either, but there are NSIS builds that can.

I'll look into using these in our CI...

@hoechenberger hoechenberger moved this to Done in 🧭 Planning Aug 16, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant