Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring of bullet points next to env name needs updating #303

Closed
kcpevey opened this issue Sep 20, 2023 · 3 comments
Closed

Coloring of bullet points next to env name needs updating #303

kcpevey opened this issue Sep 20, 2023 · 3 comments
Assignees
Labels
area: UI design 🎨 Items related to the user interface type: enhancement 💅🏼 New feature or request

Comments

@kcpevey
Copy link
Contributor

kcpevey commented Sep 20, 2023

Context

The color of the bullets next to the environment name are lighter green for non-selected envs and darker green for the selected env. The lighter green color is the same as the conda-store logo. So if you scroll such that the bullet is overlapping the logo, the bullet "disappears" (See the bullet for "xaitk-saliency-demo").

image

Value and/or benefit

Visual enhancement :)

Anything else?

No response

@kcpevey kcpevey added type: enhancement 💅🏼 New feature or request area: UI design 🎨 Items related to the user interface labels Sep 20, 2023
@smeragoel smeragoel self-assigned this Sep 22, 2023
@smeragoel
Copy link

smeragoel commented Oct 3, 2023

As a part of the work on refreshing the design files, I also updated the left sidebar. I changed the colour of the bullet points to a dark grey and that should fix this issue. I also moved the logo because having it like that in the background would always cause some unforseen contrast issues when text overlaps it. This is what it looks like now:
Left Panel

Here's the Figma Link: Conda Store Left Sidebar Figma Link

@trallard can you review this?

@smeragoel smeragoel moved this from New 🚦 to In review 👀 in conda-store 🐍 Oct 3, 2023
@kcpevey
Copy link
Contributor Author

kcpevey commented Oct 6, 2023

I like this approach. I'm happy to close this as complete, but will wait for @trallard to review

@smeragoel
Copy link

This sidebar design has already been approved and implemented here: #331 so I will mark this issue as completed!

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 💪🏾 in conda-store 🐍 Nov 28, 2023
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in conda-store 🐍 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI design 🎨 Items related to the user interface type: enhancement 💅🏼 New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants