Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triton 2.3.x #21

Closed
iamthebot opened this issue May 22, 2024 · 7 comments
Closed

Triton 2.3.x #21

iamthebot opened this issue May 22, 2024 · 7 comments
Labels
question Further information is requested

Comments

@iamthebot
Copy link

Comment:

So, the upstream github repo still does not do proper tagging of releases (see this issue). That said, looks like we do have a release commit we can use directly at least for 2.3.1.

Creating this issue to track that since the other issues are for older versions

@iamthebot iamthebot added the question Further information is requested label May 22, 2024
@iamthebot
Copy link
Author

Will take a stab at this since the existing PRs are for 2.1.x versions.

@danpetry
Copy link
Contributor

I've done some work on this here, let me know if you've got any questions/let's collaborate. Still an open question how we're going to handle the lack of pinning, but maybe we'll have the package name or version indicate this status somehow.

@iamthebot
Copy link
Author

iamthebot commented May 23, 2024

Thanks @danpetry let me read through the existing branch. I'd be very open to collaborate. BTW regarding lack of pinning... they will not add tags (for now) BUT there are clear commits on each release branch for what was used for the pypi package starting from 2.2.x. At this point, I'd say let's aim for 2.3.x.

Unfortunately that does mean updates will be semi-manual but that's better than having the conda package drift too much from the latest upstream release.

What's remaining on your branch that's not working?

@danpetry
Copy link
Contributor

Basically it needs to be tested with pytorch to see that it's working.

@danpetry
Copy link
Contributor

@iamthebot here's what we've done. It's liberally commented but if you have any questions feel free to reach out.

@mgorny
Copy link
Contributor

mgorny commented Nov 20, 2024

I'm going to try making a pull request for 3.1.0, as that's the version required by PyTorch 2.5.1.

@h-vetinari
Copy link
Member

I think this can be closed now that we have 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants