Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outlines-core #28860

Closed
wants to merge 4 commits into from
Closed

Add outlines-core #28860

wants to merge 4 commits into from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 17, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/outlines-core/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/outlines-core/meta.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [25].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12835315752. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/outlines-core/meta.yaml) and found it was in an excellent condition.

@maresb
Copy link
Contributor Author

maresb commented Jan 17, 2025

Completes the difficult half of #27820, hopefully...

@maresb
Copy link
Contributor Author

maresb commented Jan 17, 2025

    Could not find openssl via pkg-config:
    Could not run `PKG_CONFIG_PATH=/home/conda/staged-recipes/build_artifacts/outlines-core_1737141988511/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/pkgconfig PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags openssl`
    The pkg-config command could not be found.

    Most likely, you need to install a pkg-config package for your OS.
    Try `apt install pkg-config`, or `yum install pkg-config`,
    or `pkg install pkg-config`, or `apk add pkgconfig` depending on your distribution.

    If you've already installed it, ensure the pkg-config command is one of the
    directories in the PATH environment variable.

    If you did not expect this build to link to a pre-installed system library,
    then check documentation of the openssl-sys crate for an option to
    build the library from source, or disable features or dependencies
    that require pkg-config.

    cargo:warning=Could not find directory of OpenSSL installation, and this `-sys` crate cannot proceed without this knowledge. If OpenSSL is installed and this crate had trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the compilation process. See stderr section below for further information.

    --- stderr


    Could not find directory of OpenSSL installation, and this `-sys` crate cannot
    proceed without this knowledge. If OpenSSL is installed and this crate had
    trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
    compilation process.

    Make sure you also have the development packages of openssl installed.
    For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

    If you're in a situation where you think the directory *should* be found
    automatically, please open a bug at https://github.com/sfackler/rust-openssl
    and include information about your system as well as this message.

    $HOST = x86_64-unknown-linux-gnu
    $TARGET = x86_64-unknown-linux-gnu
    openssl-sys = 0.9.104


    It looks like you're compiling on Linux and also targeting Linux. Currently this
    requires the `pkg-config` utility to find OpenSSL but unfortunately `pkg-config`
    could not be found. If you have OpenSSL installed you can likely fix this by
    installing `pkg-config`.


  warning: build failed, waiting for other jobs to finish...
  error: `cargo rustc --lib --message-format=json-render-diagnostics --manifest-path Cargo.toml --target x86_64-unknown-linux-gnu --release -v --features 'python-bindings pyo3/extension-module' --crate-type cdylib -- --crate-type=cdylib` failed with code 101
  error: subprocess-exited-with-error
  
  × Building wheel for outlines_core (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

@hadim
Copy link
Member

hadim commented Jan 17, 2025

I am working on the same package at #28863

Do you want to switch over there and I add you as maintainer?

@maresb
Copy link
Contributor Author

maresb commented Jan 17, 2025

Woah cool! Add me after approval to not slow things down?

@hadim
Copy link
Member

hadim commented Jan 17, 2025

Woah cool! Add me after approval to not slow things down?

If you comment on the PR (#28863) I will add you there. If you don't, I'll do it once the feedstock has been created.

@maresb
Copy link
Contributor Author

maresb commented Jan 18, 2025

Closing in favor of #28863

@maresb maresb closed this Jan 18, 2025
@maresb maresb deleted the outlines-core branch January 18, 2025 09:49
@maresb
Copy link
Contributor Author

maresb commented Jan 18, 2025

@hadim, may I ask what's your interest in outlines? Are you using it directly?

I'm on a team that wants to use vllm, and that's a bit of a mess to get running with conda-forge.

@hadim
Copy link
Member

hadim commented Jan 18, 2025

I don't have any specific project with it. I wanted to give it a try myself and thought having it on c-f would be a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants