Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using compiler in test phase #41

Closed
jakirkham opened this issue Nov 22, 2018 · 5 comments
Closed

Using compiler in test phase #41

jakirkham opened this issue Nov 22, 2018 · 5 comments

Comments

@jakirkham
Copy link
Member

As the test phase of the recipe is making use of a C compiler for JNI testing, it would be good to use the compiler syntax to require one and update the test to be a bit more general about the compiler used. Should help make sure that JNI works nicely with the compilers we use to build other packages (including those that will make use of JNI).

@jakirkham jakirkham mentioned this issue Nov 22, 2018
@sodre
Copy link
Member

sodre commented Nov 22, 2018

I tried to add the compiler tag only to the test section but the .ci_support files did not get generated correctly. Instead of creating entries for linux and osx it only generated them for windows.

@sodre
Copy link
Member

sodre commented Nov 22, 2018

Here is the commit of the regenerated support files.

cbbf38f

@jakirkham
Copy link
Member Author

Perfect. Was just about to ask for that.

Can you please raise an issue on the conda-smithy issue tracker linking that and the previous commit with some explanation of what is (and should be) happening?

@sodre
Copy link
Member

sodre commented Nov 22, 2018

I was expecting the gcc7 and toolchain variants for linux. Maybe that will get picked up by the bot later..

@jakirkham
Copy link
Member Author

Ah ok. Yeah, that's correct. The bot will take care of that afterwards.

@sodre sodre closed this as completed in 4393f99 Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants