Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting fix for protobuf and gazebo (at least) #206

Closed
hmaarrfk opened this issue Feb 2, 2024 · 5 comments · Fixed by #207
Closed

Backporting fix for protobuf and gazebo (at least) #206

hmaarrfk opened this issue Feb 2, 2024 · 5 comments · Fixed by #207
Labels
question Further information is requested

Comments

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 2, 2024

Comment:

Could we backport:
protocolbuffers/protobuf@bb4718c

it seems to be affecting tensorflow conda-forge/tensorflow-feedstock#371
and gazebo: conda-forge/gazebo-feedstock#201

cc: @traversaro @Tobias-Fischer

@hmaarrfk hmaarrfk added the question Further information is requested label Feb 2, 2024
@h-vetinari
Copy link
Member

Hm, seems this patch hasn't been backported to the 25.x line (though 26.x already has a RC out).

If it's urgent, we'll have to create a branch for 4.25.1. Otherwise, I was planning to migrate grpc 1.61 & abseil 20240108 & protobuf 4.25.2 soon (which means we could add the patch on top of main here)

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 2, 2024

tensorflow cant be built without it.

happy to skip one combo of libabseil

@traversaro
Copy link
Contributor

tensorflow cant be built without it.

happy to skip one combo of libabseil

Same for gazebo, thanks!

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 2, 2024

The best of both worlds would to back port before you merge 4.25.2.

Happy to make the PR

@h-vetinari
Copy link
Member

Nevermind, I misremembered that I hadn't merged #202 yet. So let's go with #207 and then I'll rebase #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants