Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parm when Parser::fromFile() calls Parser::fromDocument() #4

Closed
jlayt opened this issue Jun 22, 2016 · 3 comments
Closed

Missing parm when Parser::fromFile() calls Parser::fromDocument() #4

jlayt opened this issue Jun 22, 2016 · 3 comments

Comments

@jlayt
Copy link

jlayt commented Jun 22, 2016

I'm using doctrine-xml 1.0 via Composer. In Parser::fromFile() on line 42 the call to fromDocument crashes as it doesn't pass through the $platform parameter:
return static::fromDocument($xml, $checkXml, $normalizeXml, $tableFilter);
versus
public static function fromDocument($xml, AbstractPlatform $platform, $checkXml = true, $normalizeXml = false, $tableFilter = null)
@mlocati
Copy link
Contributor

mlocati commented Jun 22, 2016

Fixed in 11f32dc

I added release 1.0.1 that includes this fix.

Thanks!

@mlocati mlocati closed this as completed Jun 22, 2016
@aembler
Copy link
Member

aembler commented Jun 22, 2016 via email

@mlocati
Copy link
Contributor

mlocati commented Jun 22, 2016

Nice job, Michele

It would have been an even nicer job if 0c78807 didn't introduce this bug 😉

@mlocati mlocati mentioned this issue Jun 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aembler @mlocati @jlayt