Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winsdk_version_conf with generator issue #15372

Closed
memsharded opened this issue Jan 2, 2024 · 4 comments · Fixed by #15373
Closed

winsdk_version_conf with generator issue #15372

memsharded opened this issue Jan 2, 2024 · 4 comments · Fixed by #15373
Assignees
@memsharded
Labels
type: bug
Milestone
2.0.17

Comments

@memsharded
Copy link
Member

memsharded commented Jan 2, 2024 •
edited
Loading

Forgive me if I'm wrong: should this be self._get_winsdk_version(system_version, generator_platform) instead?
I have following conf in profile:

tools.cmake.cmaketoolchain:generator=Visual Studio 17 2022
tools.cmake.cmaketoolchain:system_version=10.0.22000

and now I get set(CMAKE_GENERATOR_PLATFORM "Visual Studio 17 2022,version=10.0.22000" CACHE STRING "" FORCE) in conan_toolchain.cmake, which seems incorrect.

Originally posted by @mocabe in #15272 (comment)
@memsharded memsharded self-assigned this Jan 2, 2024
@memsharded
Copy link
Member Author

This seems correct, I have managed to reproduce it, the problem was that this is only fired by the CMake new policy with latest CMake cmake_minimum_required(VERSION 3.27)

@memsharded memsharded added this to the 2.0.17 milestone Jan 2, 2024
@memsharded memsharded mentioned this issue Jan 2, 2024
Merged
@memsharded
Copy link
Member Author

Thanks again for reporting @mocabe, the PR #15373 will fix it for next 2.0.17

@mocabe
Copy link

mocabe commented Jan 3, 2024

@memsharded
Thank you for your quick response, I should have made a ticket first.
Hope 2024 will be a great year for the Conan project!

@AbrilRBS AbrilRBS linked a pull request Jan 4, 2024 that will close this issue
fix winsdk_version bug #15373
Merged
@AbrilRBS
Copy link
Member

AbrilRBS commented Jan 4, 2024

Closed by #15373, to be released in 2.0.17, thanks a lot for the report! :)

@AbrilRBS AbrilRBS closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memsharded memsharded

Labels
type: bug
Projects
None yet
Milestone
2.0.17
Development

Successfully merging a pull request may close this issue.

fix winsdk_version bug memsharded/conan
3 participants
@AbrilRBS @memsharded @mocabe