Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] CMAKE_OSX_DEPLOYMENT_TARGET for macOS does not support point releases #14656

Closed
jcar87 opened this issue Sep 4, 2023 · 1 comment · Fixed by #14740
Closed

[bug] CMAKE_OSX_DEPLOYMENT_TARGET for macOS does not support point releases #14656

jcar87 opened this issue Sep 4, 2023 · 1 comment · Fixed by #14740
Assignees
Milestone

Comments

@jcar87
Copy link
Contributor

jcar87 commented Sep 4, 2023

Environment details

  • Operating System+version: macOS
  • Compiler+version: Xcode 15 (SDK 14.0) running on macOS 13.
  • Conan version: 2.0.10
  • Python version:

Steps to reproduce

Discovered this using cmake-conan's logic when passing os.version.

  • os.version is only defined in cmake-conan if CMAKE_OSX_DEPLOMENT_TARGET
  • CMAKE_OSX_DEPLOYMENT_TARGET is usually "empty" when targetting macOS, unless:
    • it is set manually
    • the SDK version detected is newer than then OS we are currently running, in that case, it is set such that the binaries are compatibles with the OS we are usin

The SDKs (and thus. os.version) support point releases as valid targets, but for macOS, settings.yml only models the .0 release for each major. For the other Apple OSs (iOS, tvOS, watchOS), we do properly track the point releases.

Suggestion: accept point releases as valid os.version setting for macOS 11+

Logs

ERROR: Invalid setting '13.5' is not a valid 'settings.os.version' value.
Possible values are ['10.6', '10.7', '10.8', '10.9', '10.10', '10.11', '10.12', '10.13', '10.14', '10.15', '11.0', '12.0', '13.0', '14.0']
@czoido
Copy link
Contributor

czoido commented Sep 14, 2023

Closed by #14740

@czoido czoido closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants