Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign UploadAPI management of package_lists and fix user confirmation #14490

Closed
memsharded opened this issue Aug 15, 2023 · 1 comment · Fixed by #14512
Closed

Redesign UploadAPI management of package_lists and fix user confirmation #14490

memsharded opened this issue Aug 15, 2023 · 1 comment · Fixed by #14512
Assignees
Milestone

Comments

@memsharded
Copy link
Member

The UploadAPI is labeling as upload: False things that we don't want to upload, and that is being used to do nothing with them. Maybe they should just be removed from the PackageList (or create and return a new package lists?)

Looks like the same problem there. Maybe we should fix that in a separate PR?

Yes, I think it is worth doing the upload in a separate PR, as there is some stuff there we need to discuss regarding the UploadAPI and how the package_lists are managed in the API. I will create a ticket dedicated from it from this comment.

Originally posted by @memsharded in #14478 (comment)

@memsharded
Copy link
Member Author

The UploadAPI is labeling as upload: False things that we don't want to upload, and that is being used to do nothing with them. Maybe they should just be removed from the PackageList (or create and return a new package lists?)

This doesn't look possible. The structure of the PackageList is:

ref
   "revisions"
        <revision>
             "packages"
                 <package_id>
...

So the first ref-revision layer is mandatory to contain the different packages-ids. But we don't always want to upload the recipe if it is already in the server. So an indicator if the recipe-revision has to be uploaded or not is necessary, we can't use the existence only for that.

Then #14512 is just fixing the printing (besides fixing the place where the user confirmation happens)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant