Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Support standard URLs in backup-source options #14341

Closed
1 task done
klimkin opened this issue Jul 20, 2023 · 2 comments · Fixed by #14342
Closed
1 task done

[feature] Support standard URLs in backup-source options #14341

klimkin opened this issue Jul 20, 2023 · 2 comments · Fixed by #14342
Assignees
@memsharded
Labels
stage: triaging
Milestone
2.0.10

Comments

@klimkin
Copy link
Contributor

klimkin commented Jul 20, 2023

What is your suggestion?

Option values for core.sources:download_urls and core.sources:upload_url should allow standard URLs . Feels like Conan2 is using str join/format instead of url join.

This works:

core.sources:download_urls=["https://artifactory.com/sources-backup/", "origin"]
core.sources:upload_url=https://artifactory.com/sources-backup/

This does not:

core.sources:download_urls=["https://artifactory.com/sources-backup", "origin"]
core.sources:upload_url=https://artifactory.com/sources-backup

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@memsharded memsharded self-assigned this Jul 20, 2023
@memsharded memsharded added this to the 2.0.10 milestone Jul 20, 2023
@memsharded memsharded mentioned this issue Jul 20, 2023
Merged
@memsharded
Copy link
Member

Thanks for reporting this @klimkin

Proposing #14342 for next 2.0.10 release.

@memsharded
Copy link
Member

#14342 merged, it will be in next 2.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memsharded memsharded

Labels
stage: triaging
Projects
None yet
Milestone
2.0.10
Development

Successfully merging a pull request may close this issue.

make last slash in backup sources urls optional memsharded/conan
2 participants
@klimkin @memsharded