You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The cmake defines that upstream SDL uses have been changed in a recent version (mainly to include SDL_ prefix, but that isn't consistent), so the ones that recipes/sdl/all/conanfile.py uses in _configure_make no longer work as of at least 2.0.18.
Package and Environment Details
Package Name/Version: sdl/2.0.18
Operating System+version: All
Compiler+version: All
Here is a rough patch to demonstrate some of the needed changes. (I discovered this from cmakes warning about unused defines). I guess to do this properly the maintainer would need to make it conditional on SDL version which names to use.
Also there was some problem with self.deps_cpp_info["libalsa"].shared, it wasn't coming out a bool for some reason, so when you set it to False it didn't work. Same for self.deps_cpp_info["pulseaudio"].shared. This is unrelated to the above, and I think they never worked.
tomazos
changed the title
[package] sdl/2.0.18: cmake defines changed
[package] sdl/2.0.18: cmake defines changed upstream
Jan 2, 2022
Also there was some problem with self.deps_cpp_info["libalsa"].shared, it wasn't coming out a bool for some reason, so when you set it to False it didn't work. Same for self.deps_cpp_info["pulseaudio"].shared. This is unrelated to the above, and I think they never worked.
It's surprising, maybe a regression in conan client? I'm pretty sure it used to return bool.
The cmake defines that upstream SDL uses have been changed in a recent version (mainly to include
SDL_
prefix, but that isn't consistent), so the ones that recipes/sdl/all/conanfile.py uses in_configure_make
no longer work as of at least 2.0.18.Package and Environment Details
Here is a rough patch to demonstrate some of the needed changes. (I discovered this from cmakes warning about unused defines). I guess to do this properly the maintainer would need to make it conditional on SDL version which names to use.
The text was updated successfully, but these errors were encountered: