list.json cannot take multiple filters

[tacman]

listing by vendor or type works as expected:

• https://packagist.org/packages/list.json?vendor=zenstruck
• https://packagist.org/packages/list.json?type=symfony-bundle

But combining the filters doesn't:

• https://packagist.org/packages/list.json?vendor=zenstruck&type=symfony-bundle

I might be able to submit a PR if someone can point me to the file where this happens.

[stof]

this is implemented in

packagist/src/Controller/PackageController.php

Line 100 in aeb9a88

public function listAction(Request $req): JsonResponse

[tacman]

My thought is to refactor that to use a QueryBuilder. Or do you have another suggestion?

[tacman]

Since this is running on Symfony 7, is there any reason not to take advantage of the cool features later Symfony versions offer, e.g.

    public function listAction(Request $req,
        #[MapQueryParameter] ?string $type=null,
        #[MapQueryParameter] ?string $vendor=null
    ): JsonResponse

[stof]

@tacman I don't see how this is relevant to this issue about supporting to combine filters instead of applying them separately.

[tacman]

What do you think about combining this into a single method getPackageNamesByVendorAndType()?

        if ($req->query->get('type')) {
            $names = $repo->getPackageNamesByType($req->query->get('type'));
        } elseif ($req->query->get('vendor')) {
            $names = $repo->getPackageNamesByVendor($req->query->get('vendor'));

to

        if ($type || $vendor ) {
            $names = $repo->getPackageNamesByVendorAndType($vendor, $type);
       }

The above looks cleaner to me, thus the MapQueryParameter