Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite SendWrapper with lighter thread Id #252

Closed
George-Miao opened this issue May 14, 2024 · 1 comment · Fixed by #261
Closed

Rewrite SendWrapper with lighter thread Id #252

George-Miao opened this issue May 14, 2024 · 1 comment · Fixed by #261
Assignees
@George-Miao
Labels
performance Performance related (regression/optimization)

Comments

@George-Miao
Copy link
Member

George-Miao commented May 14, 2024 •
edited
Loading

Current SendWrapper uses std::thread::Thread, involving cloning an Arc and instantly drop it, which causes overhead. We may rewrite it with a lighter number-only thread id.
@George-Miao George-Miao added the performance Performance related (regression/optimization) label May 14, 2024
@George-Miao George-Miao self-assigned this May 14, 2024
@Berrysoft
Copy link
Member

Trying in upstream: thk1/send_wrapper#11

@Berrysoft Berrysoft mentioned this issue May 21, 2024
Merged
@Berrysoft Berrysoft mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@George-Miao George-Miao

Labels
performance Performance related (regression/optimization)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(runtime): faster SendWrapper with cached thread id Berrysoft/compio
2 participants
@Berrysoft @George-Miao