From cea87b1a0c514596ac64b2fd78a8be9fb2b14fd4 Mon Sep 17 00:00:00 2001 From: Burak Ince Date: Fri, 17 Jan 2025 08:16:05 +0100 Subject: [PATCH] Fix wrong volume setting from the secret Signed-off-by: Burak Ince --- charts/mlflow/Chart.yaml | 4 ++-- charts/mlflow/README.md | 6 +++++- charts/mlflow/README.md.gotmpl | 4 ++++ charts/mlflow/templates/deployment.yaml | 2 +- .../mlflow/unittests/__snapshot__/deployment_test.yaml.snap | 2 +- charts/mlflow/unittests/deployment_test.yaml | 2 +- 6 files changed, 14 insertions(+), 6 deletions(-) diff --git a/charts/mlflow/Chart.yaml b/charts/mlflow/Chart.yaml index 014427e..71c83b8 100644 --- a/charts/mlflow/Chart.yaml +++ b/charts/mlflow/Chart.yaml @@ -16,7 +16,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.9.1 +version: 0.10.0 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to @@ -58,7 +58,7 @@ annotations: url: https://github.com/burakince/mlflow artifacthub.io/containsSecurityUpdates: "false" artifacthub.io/changes: | - - Change multiple json types to single type for artifacthub support + - Fix wrong volume setting from secret artifacthub.io/images: | - name: mlflow image: burakince/mlflow:2.19.0 diff --git a/charts/mlflow/README.md b/charts/mlflow/README.md index 7b73fca..0bb4d9f 100644 --- a/charts/mlflow/README.md +++ b/charts/mlflow/README.md @@ -4,7 +4,7 @@ A Helm chart for Mlflow open source platform for the machine learning lifecycle -![Version: 0.9.1](https://img.shields.io/badge/Version-0.9.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.19.0](https://img.shields.io/badge/AppVersion-2.19.0-informational?style=flat-square) +![Version: 0.10.0](https://img.shields.io/badge/Version-0.10.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.19.0](https://img.shields.io/badge/AppVersion-2.19.0-informational?style=flat-square) ## Get Helm Repository Info @@ -221,6 +221,8 @@ artifactRoot: ```yaml auth: enabled: true + adminUsername: "admin" + adminPassword: "S3cr3+" ``` Use following configuration for centralised PosgreSQL DB backend for authentication backend. @@ -228,6 +230,8 @@ Use following configuration for centralised PosgreSQL DB backend for authenticat ```yaml auth: enabled: true + adminUsername: "admin" + adminPassword: "S3cr3+" postgres: enabled: true host: "postgresql--auth-instance1.abcdef1234.eu-central-1.rds.amazonaws.com" diff --git a/charts/mlflow/README.md.gotmpl b/charts/mlflow/README.md.gotmpl index 4d82362..8f394de 100644 --- a/charts/mlflow/README.md.gotmpl +++ b/charts/mlflow/README.md.gotmpl @@ -221,6 +221,8 @@ artifactRoot: ```yaml auth: enabled: true + adminUsername: "admin" + adminPassword: "S3cr3+" ``` Use following configuration for centralised PosgreSQL DB backend for authentication backend. @@ -228,6 +230,8 @@ Use following configuration for centralised PosgreSQL DB backend for authenticat ```yaml auth: enabled: true + adminUsername: "admin" + adminPassword: "S3cr3+" postgres: enabled: true host: "postgresql--auth-instance1.abcdef1234.eu-central-1.rds.amazonaws.com" diff --git a/charts/mlflow/templates/deployment.yaml b/charts/mlflow/templates/deployment.yaml index df6374f..beadeae 100644 --- a/charts/mlflow/templates/deployment.yaml +++ b/charts/mlflow/templates/deployment.yaml @@ -211,7 +211,7 @@ spec: {{- if .Values.auth.enabled }} - name: auth-config-secret secret: - name: {{ template "mlflow.fullname" . }}-auth-config-secret + secretName: {{ template "mlflow.fullname" . }}-auth-config-secret {{- end }} {{- with .Values.extraVolumes }} {{- toYaml . | nindent 8 }} diff --git a/charts/mlflow/unittests/__snapshot__/deployment_test.yaml.snap b/charts/mlflow/unittests/__snapshot__/deployment_test.yaml.snap index fea6521..973fd4c 100644 --- a/charts/mlflow/unittests/__snapshot__/deployment_test.yaml.snap +++ b/charts/mlflow/unittests/__snapshot__/deployment_test.yaml.snap @@ -250,7 +250,7 @@ should match snapshot with additional values: name: migrations-config - name: auth-config-secret secret: - name: mlflow-auth-config-secret + secretName: mlflow-auth-config-secret - name: mlflow-volume persistentVolumeClaim: claimName: mlflow-pv-volume diff --git a/charts/mlflow/unittests/deployment_test.yaml b/charts/mlflow/unittests/deployment_test.yaml index 9944ea5..fc02c47 100644 --- a/charts/mlflow/unittests/deployment_test.yaml +++ b/charts/mlflow/unittests/deployment_test.yaml @@ -545,7 +545,7 @@ tests: path: spec.template.spec.volumes[0].name value: auth-config-secret - equal: - path: spec.template.spec.volumes[0].secret.name + path: spec.template.spec.volumes[0].secret.secretName value: mlflow-auth-config-secret - it: should match snapshot of default values