You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#34528 broke compressed logs. It wasn't caught in CI since we use what's on disk in CI, which isn't what gets uploaded. We can add tests, but I think we should also investigate moving the compression back to loggerd.
IIRC we did that for two reason:
CPU usage
Getting as much as possible in the case of sudden power loss
#1 should be much better with zstd, and #2 is better defined now.
The text was updated successfully, but these errors were encountered:
@adeebshihadeh The issue occurred because the original LogReader was using zstd.decompress(data) and was unable to handle streaming zstd-compressed logs. This has been fixed in in PR #34549.
#34528 broke compressed logs. It wasn't caught in CI since we use what's on disk in CI, which isn't what gets uploaded. We can add tests, but I think we should also investigate moving the compression back to loggerd.
IIRC we did that for two reason:
#1 should be much better with zstd, and #2 is better defined now.
The text was updated successfully, but these errors were encountered: