Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-semVer #17

Open
koppor opened this issue Oct 22, 2023 · 1 comment
Open

Support non-semVer #17

koppor opened this issue Oct 22, 2023 · 1 comment

Comments

@koppor
Copy link

koppor commented Oct 22, 2023

I found this library while looking to an alternative of clparse (which I was recommended at NiclasvanEyk/keepac#20 (comment)).

My tool is not using SemVer, but using keep-a-changelog-format. Example: https://github.com/JabRef/jabref/blob/v5.11/CHANGELOG.md. I am also using en dashes for separation (so that the CHANGELOG.md looks nicer to end users).

https://github.com/colindean/keepachangelog-parser-java seems to enforce SemVer.

Just wanted to let you know about this.

Think, I will continue working on heylogs. While keepachangelog-java-parser has a better internal data model, heylogs offers more functionality. Still working on getting it implementing my wish (nbbrd/heylogs#146).

@colindean
Copy link
Owner

I could pretty easily allow an endash in addition to a dash for the date separator:

https://github.com/colindean/keepachangelog-parser-java/blob/17f83b20a9e355cc64cbb4c46a4c8b54e14220b8/src/main/java/cx/cad/keepachangelog/internal/ChangelogExtractor.java#L34C66-L34C66

The SemVer impl comes from

and is from an old version:

compile group: 'com.github.zafarkhaja', name: 'java-semver', version: '0.9.0'

Latest appears to be 0.10.0 and on a very quick glance it looks like it allows weak SemVer in #.# that you're using.

I don't know when I'd get around to making these changes, but I'd happily take a PR if you'd like to submit one. I don't consider this codebase abandoned but it's definitely in a "when I feel like it" maintenance mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants