Add defaults to resetFields call when creating new contact #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in webform_civicrm_forms.js, solving the bug of missing CiviCRM defaults.
Overview
When creating a new contact in a webform, defaults for Civi fields are not preserved, while defaults for non-Civi fields remain. This change preserves the defaults for Civi fields as well.
Before
This is our Test Defaults webform:



Here is what happens when selecting an existing Contact (all defaults are preserved, fields with saved data are updated):
Here is what happens when creating a new contact (Civi defaults are not preserved):
After
Now all defaults are preserved when creating a new Contact:

Technical Details
The defaults parameter of the resetFields function seems to be relatively new. It looks like it can be used when creating a new Contact, and adding it here doesn't appear to break anything else (but maybe there's a use case I'm not considering).