Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow token to be a default value for contribution amount #136

Merged
merged 1 commit into from
May 1, 2018

Conversation

jitendrapurohit
Copy link
Collaborator

Overview

Allow token string to be a default value for contribution amount input field.

Before

Error when token string is passed to the default value of contribution amount.

image

After

Fixed.

Technical Details

Validation function is modified to not error for token string using token_replace function.

Tested string value

  • abc - errors
  • [current-page:query:civicrm_1_contribution_1_contribution_total_amount] - works fine.

@KarinG
Copy link
Collaborator

KarinG commented May 1, 2018

Excellent - all tested/reviewed on two continents; thank you @jitendrapurohit and @fuzionnz

@KarinG KarinG merged commit 9ade961 into colemanw:7.x-4.x May 1, 2018
@jitendrapurohit jitendrapurohit deleted the tokenfix branch May 2, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants