Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new behavior to autocomplete component #85

Merged
merged 16 commits into from
May 4, 2024
Merged

Add new behavior to autocomplete component #85

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
66b9217
added fillOnSelected, clearOnSelected, and blurOnSelect to autocomplete
Apr 26, 2024
29a9128
remove clearOnSelect
Apr 26, 2024
87344b8
new implementation
Apr 26, 2024
6a1113d
revert change to index.js
Apr 26, 2024
5621579
tidy
Apr 26, 2024
ef65ec1
tidy
Apr 26, 2024
7921c4d
prevent default doesn't work in this case
Apr 26, 2024
ea43005
prop fixes
Apr 26, 2024
b9cf351
new approach
Apr 29, 2024
94222db
tidy
Apr 30, 2024
2eefe2b
fix tab not dismissing suggestions
Apr 30, 2024
c97cdb7
update tab method
Apr 30, 2024
716849e
tidy
Apr 30, 2024
b8169c2
fix tab behavior
May 1, 2024
c500dc9
handleKeyTab uses handleKeyEnter
May 2, 2024
e52b252
update autocomplete
May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions packages/autocomplete/src/autocomplete.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@keydown.up.native.prevent="highlight(highlightedIndex - 1)"
@keydown.down.native.prevent="highlight(highlightedIndex + 1)"
@keydown.enter.native="handleKeyEnter"
@keydown.native.tab="handleKeyEnter"
@keydown.native.tab="handleKeyTab"
>
<template slot="prepend" v-if="$slots.prepend">
<slot name="prepend"></slot>
Expand Down Expand Up @@ -139,6 +139,10 @@
blurOnSelect: {
type: Boolean,
default: true
},
tabSelectsSuggestion: {
type: Boolean,
default: false
}
},
data() {
Expand All @@ -148,7 +152,7 @@
loading: false,
highlightedIndex: -1,
suggestionDisabled: false,
selected: false
handledSelection: false
};
},
computed: {
Expand Down Expand Up @@ -198,9 +202,9 @@
},
handleInput(value) {
this.$emit('input', value);
this.selected = false;
if (!this.blurOnSelect) { this.$refs.input.ignoreNextBlur(true); }
this.handledSelection = false;
this.suggestionDisabled = false;
if (!this.blurOnSelect) { this.$refs.input.ignoreNextBlur(true); }
if (!this.triggerOnFocus && !value) {
this.suggestionDisabled = true;
this.suggestions = [];
Expand All @@ -219,7 +223,6 @@
}
},
handleBlur(event) {
this.activated = false;
this.$emit('blur', event);
},
handleClear() {
Expand All @@ -228,11 +231,18 @@
},
close(e) {
this.activated = false;
if (!this.selected && !this.blurOnSelect) {
this.selected = true;
if (!this.handledSelection && !this.blurOnSelect) {
this.$refs.input.blur();
}
},
handleKeyTab(e) {
if (this.tabSelectsSuggestion) {
this.select(this.suggestions[this.highlightedIndex]);
} else {
if (!this.blurOnSelect) { this.$refs.input.ignoreNextBlur(false); }
this.close(e);
}
},
handleKeyEnter(e) {
if (!this.blurOnSelect) { this.$refs.input.ignoreNextBlur(false); }
if (this.suggestionVisible && this.highlightedIndex >= 0 && this.highlightedIndex < this.suggestions.length) {
Expand All @@ -247,7 +257,7 @@
}
},
select(item) {
this.selected = true;
this.handledSelection = true;
if (this.fillOnSelect) { this.$emit('input', item[this.valueKey]); }
this.$emit('select', item);
this.$nextTick(_ => {
Expand Down