Fix SubMenu Accessibility #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-cognito
reviewed
May 5, 2022
src/utils/menu/aria-submenu.js
Outdated
| // Grab focusable menu items that are not hidden | ||
| let test = this.domNode.querySelectorAll('[class^="el-menu--"]:not([style*="display: none"]) > .el-menu > li'); | ||
| // If current idx is not focusable, skip it | ||
| while (!Array.from(test).includes(this.subMenuItems[idx]) && ((isDown && idx < this.subMenuItems.length) || (!isDown && idx >= 0))) { |
There was a problem hiding this comment.
does this need to be ES5 compatible? not sure if Array.from would have been polyfilled here yet
There was a problem hiding this comment.
Should be fine since workflow will not be supported in IE, but made it ES5 compatible just in case.
tskimmett
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tabbing for Menu and SubMenu components so only shown items can be tabbed to. And submenus open with 'enter' now too.