Update multi select input to stay on the same line when typing with tags #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskimmett
requested changes
Feb 16, 2022
packages/select/src/select.vue
Outdated
| v-model="query" | ||
| @input="debouncedQueryChange" | ||
| v-if="filterable" | ||
| :style="{ 'flex-grow': '1', width: selected.length > 0 ? (query.length > 0 ? query.length + 2 + 'ch':'2ch' ) : '100%', 'max-width': '100%' }" |
There was a problem hiding this comment.
Move the width calculation into a computed since it is a bit hairy for inlining into the template.
There was a problem hiding this comment.
Moved into computed, multiSelectInputWidth
tskimmett
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the input inside of the tags container so it will stay inline with them when typing.