Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Tabs rendered as sequential text on page #5

Closed
acgrama opened this issue Jul 18, 2017 · 2 comments
Closed

Tabs rendered as sequential text on page #5

acgrama opened this issue Jul 18, 2017 · 2 comments

Comments

@acgrama
Copy link

acgrama commented Jul 18, 2017

Hi,

I have used some code from your dummy application to try out the ember-paper-tabs:

  {{#paper-card as |card|}}
    {{#paper-toolbar as |toolbar|}}
      {{#toolbar.tools}}
        <h2>Dynamic Height</h2>
      {{/toolbar.tools}}
    {{/paper-toolbar}}

  {{#paper-tabs dynamicHeight=true as |tabs|}}
    {{#tabs.tab label="ONE" as |tab|}}
      {{#card.content class="md-padding"}}
        <h1 class="md-display-2">Tab One</h1>
        <p>...</p>
      {{/card.content}}
    {{/tabs.tab}}
    {{#tabs.tab label="TWO" as |tab|}}
      {{#card.content class="md-padding"}}
        <h1 class="md-display-2">Tab Two</h1>
        <p>...</p>
      {{/card.content}}
    {{/tabs.tab}}
    {{#tabs.tab label="THREE" as |tab|}}
      {{#card.content class="md-padding"}}
        <h1 class="md-display-2">Tab Three</h1>
        <p>...</p>
      {{/card.content}}
    {{/tabs.tab}}
  {{/paper-tabs}}

{{/paper-card}}

But the rendered result looks like this:
tabs

Do you have any idea what might be going on?
Thanks a lot!

@panthony
Copy link
Member

Did you include the scss?

In your app.scss:

@import "ember-paper-tabs";

But be aware that they are issues with this current version and I do not have time at the moment to fix them.

This addon was a temporary solution while the PR is finalized and merged in main repository:

adopted-ember-addons/ember-paper#578

@acgrama
Copy link
Author

acgrama commented Jul 19, 2017

Ah yes, that might be it, sorry for the trouble! (working with pre-existing code & styling, forgot to check that the scss was there...)

I'm glad to hear this will be a part of the stable build.

@acgrama acgrama closed this as completed Jul 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants