Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make react-components CI trigger during CD for codecov updates #5016

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Feb 24, 2025

Type of change

Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-5450

Description 📝

Trigger react components CI step in CD as well to update codecov base branch. Currently the base commit on codecov is very old, due to coverage reports being connected to a specific commit which gets squashed away. Simply running the codecov in CD should tag commits in the master branch with codecov info.

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.88%. Comparing base (dfe17bb) to head (3460843).
Report is 666 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5016       +/-   ##
===========================================
- Coverage   71.10%   29.88%   -41.23%     
===========================================
  Files         378      667      +289     
  Lines       38591    54375    +15784     
  Branches     2774      598     -2176     
===========================================
- Hits        27442    16252    -11190     
- Misses      11039    37871    +26832     
- Partials      110      252      +142     

see 1045 files with indirect coverage changes

@christjt christjt enabled auto-merge (squash) February 24, 2025 15:38
@christjt christjt requested review from a team and rbtcollins and removed request for a team February 24, 2025 15:55
@christjt christjt merged commit d127b1c into master Feb 25, 2025
16 of 17 checks passed
@christjt christjt deleted the christjt/BND3D-5450 branch February 25, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants