Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-component): Add TreeView #4987

Merged
merged 25 commits into from
Feb 21, 2025
Merged

feat(react-component): Add TreeView #4987

merged 25 commits into from
Feb 21, 2025

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Feb 10, 2025

Type of change

Feat

Jira ticket 📘

Description 📝

The advance-tree-view folder is not for Review. This is a copy of already reviewed stuff

The must important stuff is the DomainObject implements the TreeNodeType. This is the changed that brings the Domainobjects in the tree. All other changes in the domain objects is to tune the tree with correct color, label and language translation.

TheTreeView component set up the Three and should be used.

I have made it possible to use it in storybook. This will not be the final tree, but use for testing and developing.
The ShowTreeViewCommand show or hide the tree in storybook.

I also make a Translator file. This is code that is moved from a hook, so it can be used in the business layer of the code.

How has this been tested? 🔍

Test instructions ℹ️

pramod-cog
pramod-cog previously approved these changes Feb 21, 2025
pramod-cog
pramod-cog previously approved these changes Feb 21, 2025
pramod-cog
pramod-cog previously approved these changes Feb 21, 2025
pramod-cog
pramod-cog previously approved these changes Feb 21, 2025
pramod-cog
pramod-cog previously approved these changes Feb 21, 2025
@nilscognite nilscognite merged commit 418f381 into master Feb 21, 2025
14 checks passed
@nilscognite nilscognite deleted the np/tree branch February 21, 2025 14:39
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 15.83942% with 2306 lines in your changes missing coverage. Please review.

Project coverage is 29.87%. Comparing base (dfe17bb) to head (9565014).
Report is 664 commits behind head on master.

Files with missing lines Patch % Lines
...mponents/src/advanced-tree-view/model/tree-node.ts 6.37% 470 Missing ⚠️
...vanced-tree-view/storybook-cad/cad-nodes-loader.ts 0.00% 186 Missing and 1 partial ⚠️
...tree-view/storybook/advanced-tree-view.stories.tsx 0.00% 175 Missing and 1 partial ⚠️
...ced-tree-view/storybook-cad/cognite-client-mock.ts 0.00% 154 Missing and 1 partial ⚠️
...dvanced-tree-view/view/advanced-tree-view-node.tsx 16.66% 145 Missing ⚠️
...c/advanced-tree-view/storybook/lazy-loader-mock.ts 0.00% 129 Missing and 1 partial ⚠️
...-tree-view/storybook-cad/cad-tree-view.stories.tsx 0.00% 120 Missing and 1 partial ⚠️
.../advanced-tree-view/storybook-cad/cad-tree-node.ts 0.00% 113 Missing and 1 partial ⚠️
...rc/advanced-tree-view/model/tree-node-functions.ts 36.15% 83 Missing ⚠️
...advanced-tree-view/storybook/create-simple-mock.ts 0.00% 56 Missing and 1 partial ⚠️
... and 38 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4987       +/-   ##
===========================================
- Coverage   71.10%   29.87%   -41.24%     
===========================================
  Files         378      667      +289     
  Lines       38591    54367    +15776     
  Branches     2774      593     -2181     
===========================================
- Hits        27442    16244    -11198     
- Misses      11039    37871    +26832     
- Partials      110      252      +142     
Files with missing lines Coverage Δ
react-components/src/advanced-tree-view/index.ts 100.00% <100.00%> (ø)
...t-components/src/advanced-tree-view/model/types.ts 100.00% <100.00%> (ø)
...omponents/src/advanced-tree-view/view/constants.ts 100.00% <100.00%> (ø)
.../src/architecture/base/utilities/TranslateInput.ts 66.66% <100.00%> (ø)
...s/src/architecture/concrete/clipping/ClipFolder.ts 83.33% <ø> (ø)
...tecture/concrete/measurements/MeasurementFolder.ts 83.33% <ø> (ø)
...chitecture/base/renderTarget/RevealRenderTarget.ts 51.62% <0.00%> (ø)
...rete/annotation360/Image360AnnotationCreateTool.ts 46.75% <0.00%> (ø)
...nts/src/architecture/concrete/clipping/ClipTool.ts 60.00% <0.00%> (ø)
...hitecture/concrete/measurements/MeasurementTool.ts 44.64% <0.00%> (ø)
... and 44 more

... and 991 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants