Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): add support for Hybrid CAD asset mappings for hybrid projects #4975

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Merge remote-tracking branch 'origin/master' into danpriori/BND3D-498…

adaa3ae
Select commit
Loading
Failed to load commit list.
Open

feat(react-components): add support for Hybrid CAD asset mappings for hybrid projects #4975

Merge remote-tracking branch 'origin/master' into danpriori/BND3D-498…
adaa3ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 25, 2025 in 0s

18.36% (-52.74%) compared to dfe17bb

View this Pull Request on Codecov

18.36% (-52.74%) compared to dfe17bb

Details

Codecov Report

Attention: Patch coverage is 10.68648% with 1262 lines in your changes missing coverage. Please review.

Project coverage is 18.36%. Comparing base (dfe17bb) to head (adaa3ae).
Report is 667 commits behind head on master.

Files with missing lines Patch % Lines
...onents/CacheProvider/AssetMappingAndNode3DCache.ts 5.64% 234 Missing ⚠️
...rc/query/useSearchMappedEquipmentAssetMappings.tsx 0.00% 146 Missing ⚠️
...src/utilities/fetchMappedEquipmentAssetMappings.ts 0.00% 90 Missing and 1 partial ⚠️
...veal3DResources/hooks/useCalculateMappedStyling.ts 9.57% 85 Missing ⚠️
...t-components/stories/utilities/SearchComponent.tsx 0.00% 72 Missing ⚠️
...ponents/CacheProvider/AssetMappingPerModelCache.ts 7.24% 64 Missing ⚠️
...al3DResources/hooks/useCalculateInstanceStyling.ts 14.70% 58 Missing ⚠️
...components/src/hooks/cad/useHybridAssetMappings.ts 16.66% 55 Missing ⚠️
...ooks/utils/calculateAssetMappingCadModelStyling.ts 10.00% 27 Missing ⚠️
...ts/Reveal3DResources/hooks/useJoinStylingGroups.ts 18.75% 26 Missing ⚠️
... and 53 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #4975       +/-   ##
===========================================
- Coverage   71.10%   18.36%   -52.74%     
===========================================
  Files         378      703      +325     
  Lines       38591    37322     -1269     
  Branches     2774      615     -2159     
===========================================
- Hits        27442     6856    -20586     
- Misses      11039    30198    +19159     
- Partials      110      268      +158
Files with missing lines Coverage Δ
...re/concrete/annotations/helpers/AnnotationUtils.ts 9.39% <ø> (ø)
...ointsOfInterest/ads/PointsOfInterestAdsProvider.ts 15.82% <ø> (ø)
...t-components/src/components/CacheProvider/index.ts 0.00% <ø> (ø)
...t-components/src/components/CacheProvider/types.ts 0.00% <ø> (ø)
...mponents/src/components/Reveal3DResources/index.ts 0.00% <ø> (ø)
...mponents/src/components/Reveal3DResources/types.ts 0.00% <ø> (ø)
...components/src/hooks/cad/ModelWithAssetMappings.ts 0.00% <ø> (ø)
react-components/src/hooks/cad/index.ts 100.00% <ø> (ø)
...nents/src/hooks/cad/useAssetMappingForTreeIndex.ts 13.95% <ø> (ø)
...eact-components/src/hooks/cad/useNodesForAssets.ts 12.90% <ø> (ø)
... and 69 more

... and 1002 files with indirect coverage changes

View more details on Codecov