-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): add support for Hybrid CAD asset mappings for hybrid projects #4975
Open
danpriori
wants to merge
42
commits into
master
Choose a base branch
from
danpriori/BND3D-4989-add-support-for-core-dm-mappings-along-with-classic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(react-components): add support for Hybrid CAD asset mappings for hybrid projects #4975
danpriori
wants to merge
42
commits into
master
from
danpriori/BND3D-4989-add-support-for-core-dm-mappings-along-with-classic
+2,188
−721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wip Need the SDK changes along with this to take effect. -same branch name
…9-add-support-for-core-dm-mappings-along-with-classic
…d functions involved on requesting assets
…9-add-support-for-core-dm-mappings-along-with-classic
…gs and fix the asset mapping per model cache to include hybrid
…9-add-support-for-core-dm-mappings-along-with-classic
…n fetching asset for asset reference
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingPerModelCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingHybridPerAssetInstanceIdCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingHybridPerAssetInstanceIdCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AssetMappingAndNode3DCache.ts
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/CacheProvider/AnnotationModelUtils.ts
Outdated
Show resolved
Hide resolved
pramod-cog
reviewed
Feb 4, 2025
react-components/src/components/Architecture/pointsOfInterest/PoiSharePanel.tsx
Outdated
Show resolved
Hide resolved
pramod-cog
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have reviewed half way as it contain big changes, will look into the rest and have to test tomorrow.
…odelCache.ts Co-authored-by: pramod-cog <pramod.s@cognite.com>
…-for-core-dm-mappings-along-with-classic' into danpriori/BND3D-4989-add-support-for-core-dm-mappings-along-with-classic
…dm-mappings-along-with-classic
…-for-core-dm-mappings-along-with-classic' into danpriori/BND3D-4989-add-support-for-core-dm-mappings-along-with-classic
… global const and fix the click 3d node of hybrid mappings
…with the mapped found
…9-add-support-for-core-dm-mappings-along-with-classic
…9-add-support-for-core-dm-mappings-along-with-classic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
BND3D-4989
https://cognitedata.atlassian.net/browse/
Description 📝
Adds the support for Hybrid CAD asset mappings in hybrid projects using the classic endpoints of the list and filter of the assetMappings3D API, which are connected to DMS instances of the CDM Asset (CogniteAssets).
Because it uses a hybrid connection method (using the classic endpoints but mapped with the CDM Asset instance and in a currently limited way), it was necessary to create a separate line for retrieving, filtering and processing this mapping that is not raw via FDM or via Classic Assets. However, abstracting this logic from the user, where the user views the Cognite Asset mappings in a similar way as if it were a Core DM Only project in the 3D Browser side panel.
With this feature, it is possible to:
Note 1: This PR should be seen together with the PR on Fusion:
Note 2: the support only works with Cognite JS SDK v10 latest
Test instructions ℹ️
You will see the 3d nodes involved being focused and highlighted, in addition to the preview panel appearing with the Cognite Asset data.
hybrid-cad-mappings.webm
Checklist ☑️