Merge branch 'master' into np/unit-test2

cognitedata · Feb 26, 2025 · e390b24 · e390b24
2 parents c0796ae + a7a94a5
commit e390b24
Show file tree

Hide file tree

Showing 10 changed files with 902 additions and 23 deletions.
diff --git a/react-components/src/advanced-tree-view/storybook-cad/cad-tree-view.stories.tsx b/react-components/src/advanced-tree-view/storybook-cad/cad-tree-view.stories.tsx
@@ -33,8 +33,8 @@ type Story = StoryObj<typeof AdvancedTreeView>;
 
 export default meta;
 
-const stk = new CogniteClientMock();
-const baseLoader = new CadNodesLoader(stk, { revisionId: 1, modelId: 1 }, 10);
+const sdk = new CogniteClientMock();
+const baseLoader = new CadNodesLoader(sdk, { revisionId: 1, modelId: 1 }, 10);
 
 export const base: Story = {
   name: 'base',
@@ -51,7 +51,7 @@ export const base: Story = {
   }
 };
 
-const loader = new CadNodesLoader(stk, { revisionId: 1, modelId: 1 }, 10);
+const loader = new CadNodesLoader(sdk, { revisionId: 1, modelId: 1 }, 10);
 
 export const Main: Story = {
   name: 'main',
@@ -80,7 +80,7 @@ export const Main: Story = {
         <StyledButton
           size="small"
           onClick={async () => {
-            const nodeId = stk.getRandomNodeId();
+            const nodeId = sdk.getRandomNodeId();
             await loader.forceNodeInTree(nodeId).then((selectedNode) => {
               if (selectedNode === undefined) {
                 return;

diff --git a/react-components/src/architecture/base/commands/factory/ToolbarFactory.test.ts b/react-components/src/architecture/base/commands/factory/ToolbarFactory.test.ts
@@ -25,15 +25,15 @@ describe('ToolbarFactory', () => {
   test('should test get toolbar', () => {
     const tool = new FooTool();
     const toolBar = getToolbar(tool);
-    expect(toolBar).not.toBe(undefined);
+    expect(toolBar).toBeDefined();
     if (toolBar !== undefined) {
       expect(toolBar.length).toEqual(2);
     }
   });
 
   test('should test can not get toolbar', () => {
     const tool = new BarTool();
-    expect(getToolbar(tool)).toBe(undefined);
+    expect(getToolbar(tool)).toBeUndefined();
   });
 });