diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java index 7cd66de8b88283..5ccce705a0a798 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java @@ -93,15 +93,6 @@ public class AnalysisOptions extends OptionsBase { ) public long versionWindowForDirtyNodeGc; - @Option( - name = "experimental_skyframe_prepare_analysis", - deprecationWarning = "This flag is a no-op and will be deleted in a future release.", - defaultValue = "false", - documentationCategory = OptionDocumentationCategory.UNDOCUMENTED, - effectTags = {OptionEffectTag.BAZEL_INTERNAL_CONFIGURATION}, - help = "Deprecated. No-op.") - public boolean skyframePrepareAnalysis; - @Option( name = "experimental_skyframe_cpu_heavy_skykeys_thread_pool_size", defaultValue = "HOST_CPUS", diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java index 8ed88b7b019213..0ce9cb9b903a53 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java @@ -44,6 +44,15 @@ public final class BazelRulesModule extends BlazeModule { */ @SuppressWarnings("deprecation") // These fields have no JavaDoc by design public static class BuildGraveyardOptions extends OptionsBase { + @Option( + name = "experimental_skyframe_prepare_analysis", + deprecationWarning = "This flag is a no-op and will be deleted in a future release.", + defaultValue = "false", + documentationCategory = OptionDocumentationCategory.UNDOCUMENTED, + effectTags = {OptionEffectTag.BAZEL_INTERNAL_CONFIGURATION}, + help = "Deprecated. No-op.") + public boolean skyframePrepareAnalysis; + @Option( name = "incompatible_use_platforms_repo_for_constraints", defaultValue = "true", diff --git a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java index 28bdc4ffdd443d..049b1ed8f0f162 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java @@ -1406,13 +1406,4 @@ public void testExistingRules() throws Exception { update("//pkg:foo"); assertContainsEvent("DEBUG /workspace/pkg/BUILD:5:6: [\"foo\"]"); } - - /** Runs the same test with the Skyframe-based analysis prep. */ - @RunWith(JUnit4.class) - public static class WithSkyframePrepareAnalysis extends BuildViewTest { - @Override - protected FlagBuilder defaultFlags() { - return super.defaultFlags().with(Flag.SKYFRAME_PREPARE_ANALYSIS); - } - } } diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java index a2672c0eafba21..c4ed837cb04297 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java @@ -122,8 +122,6 @@ public abstract class AnalysisTestCase extends FoundationTestCase { public enum Flag { // The --keep_going flag. KEEP_GOING, - // The --skyframe_prepare_analysis flag. - SKYFRAME_PREPARE_ANALYSIS, // Flags for visibility to default to public. PUBLIC_VISIBILITY, // Flags for CPU to work (be set to k8) in test mode. @@ -418,7 +416,6 @@ protected AnalysisResult update( // update --keep_going option if test requested it. boolean keepGoing = flags.contains(Flag.KEEP_GOING); boolean discardAnalysisCache = viewOptions.discardAnalysisCache; - viewOptions.skyframePrepareAnalysis = flags.contains(Flag.SKYFRAME_PREPARE_ANALYSIS); PackageOptions packageOptions = optionsParser.getOptions(PackageOptions.class); PathPackageLocator pathPackageLocator =