You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"Let's" is a contraction of "let us", while "lets" is the third-person singular form of the verb "let". In #3468 the lets->let's mapping was added. While people indeed frequently misspell "let's" as "lets", I'd argue that the correct use of "lets" may be frequent enough that such a mapping does more harm than good.
I've updated codespell to 2.4.1 in our Lombiq's Open-Source Orchard Core Extensions project, including that it also runs for its submodules. While this might not be representative, it contains about 51k LOC in C#, and I'd guess at least a further 10k in CSS, JS, MD, YML, PS1, and other files.
After the update, I've got 17 errors for "lets", with a single one being an actual misspelling, 16 being false positives. So, it seems to me that this mapping is not useful. Thus, I'd ask you to please reconsider it, and I suggest removing it.
The text was updated successfully, but these errors were encountered:
"Let's" is a contraction of "let us", while "lets" is the third-person singular form of the verb "let". In #3468 the
lets->let's
mapping was added. While people indeed frequently misspell "let's" as "lets", I'd argue that the correct use of "lets" may be frequent enough that such a mapping does more harm than good.I've updated codespell to 2.4.1 in our Lombiq's Open-Source Orchard Core Extensions project, including that it also runs for its submodules. While this might not be representative, it contains about 51k LOC in C#, and I'd guess at least a further 10k in CSS, JS, MD, YML, PS1, and other files.
After the update, I've got 17 errors for "lets", with a single one being an actual misspelling, 16 being false positives. So, it seems to me that this mapping is not useful. Thus, I'd ask you to please reconsider it, and I suggest removing it.
The text was updated successfully, but these errors were encountered: