Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider "lets" being a common misspelling of "let's" #3629

Closed
Piedone opened this issue Feb 3, 2025 · 2 comments · Fixed by #3633
Closed

Reconsider "lets" being a common misspelling of "let's" #3629

Piedone opened this issue Feb 3, 2025 · 2 comments · Fixed by #3633
Labels
dictionary Changes to the dictionary

Comments

@Piedone
Copy link
Contributor

Piedone commented Feb 3, 2025

"Let's" is a contraction of "let us", while "lets" is the third-person singular form of the verb "let". In #3468 the lets->let's mapping was added. While people indeed frequently misspell "let's" as "lets", I'd argue that the correct use of "lets" may be frequent enough that such a mapping does more harm than good.

I've updated codespell to 2.4.1 in our Lombiq's Open-Source Orchard Core Extensions project, including that it also runs for its submodules. While this might not be representative, it contains about 51k LOC in C#, and I'd guess at least a further 10k in CSS, JS, MD, YML, PS1, and other files.

After the update, I've got 17 errors for "lets", with a single one being an actual misspelling, 16 being false positives. So, it seems to me that this mapping is not useful. Thus, I'd ask you to please reconsider it, and I suggest removing it.

@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Feb 3, 2025
@DimitriPapadopoulos
Copy link
Collaborator

Ooops... Sorry for letting this through. Would you agree to create a PR to revert?

@Piedone
Copy link
Contributor Author

Piedone commented Feb 3, 2025

Oh sure: #3633. Thank you for your quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants