-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented Dev Dependencies #2896
Comments
@DimitriPapadopoulos @larsoner Are you two opposed to me adding both these as dev dependencies or are there some ramifications to this I'm not aware of? Alternatively, I could add documentation for this in the README. |
I don't know about twine, but the main aim with not including aspell was to stop every individual having to pull it in when they just want to add a dictionary entry, given the majority won't be in there anyway. aspell is really just a further safety net that we haven't accidentally added some obscure word as a typo. |
@Casey-Kiewit Indeed |
Agreed |
While working on #2877, I noticed that a few additional dependencies aren't currently documented or listed as dev dependencies. These also seem to be fine to install without Aspell, resulting the the checks being skipped as normal.
The additional dependencies required if Aspell is installed for additional testing:
The text was updated successfully, but these errors were encountered: