Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented Dev Dependencies #2896

Closed
korverdev opened this issue Jun 24, 2023 · 4 comments · Fixed by #2901
Closed

Undocumented Dev Dependencies #2896

korverdev opened this issue Jun 24, 2023 · 4 comments · Fixed by #2901

Comments

@korverdev
Copy link
Contributor

While working on #2877, I noticed that a few additional dependencies aren't currently documented or listed as dev dependencies. These also seem to be fine to install without Aspell, resulting the the checks being skipped as normal.

The additional dependencies required if Aspell is installed for additional testing:

  • aspell-python-py3
  • twine
@korverdev
Copy link
Contributor Author

@DimitriPapadopoulos @larsoner Are you two opposed to me adding both these as dev dependencies or are there some ramifications to this I'm not aware of? Alternatively, I could add documentation for this in the README.

@peternewman
Copy link
Collaborator

I don't know about twine, but the main aim with not including aspell was to stop every individual having to pull it in when they just want to add a dictionary entry, given the majority won't be in there anyway. aspell is really just a further safety net that we haven't accidentally added some obscure word as a typo.

@DimitriPapadopoulos
Copy link
Collaborator

@Casey-Kiewit Indeed twine should have been added to the dev dependencies in #2626. A merge request to add it would be great.

@larsoner
Copy link
Member

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants