Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml config not supported? #2522

Closed
banesullivan opened this issue Oct 11, 2022 · 5 comments
Closed

pyproject.toml config not supported? #2522

banesullivan opened this issue Oct 11, 2022 · 5 comments
Labels
packaging packaging related issue question

Comments

@banesullivan
Copy link
Contributor

The README states:

Codespell will also check in the current directory for a pyproject.toml (or a path can be specified via --toml ) file, and the [tool.codespell] entry will be used as long as the tomli package is installed, for example

However, I have been unable to get this to work in both pyvista/pyvista#3328 and in this standalone repository: https://github.com/banesullivan/codespell-pyproject-issue

The tomli package is installed yet codespell does not pick up on the pyproject.toml configuration.

You can see this erroring in https://github.com/banesullivan/codespell-pyproject-issue/actions/runs/3230877580/jobs/5289808823#step:5:12 where the ignored.txt file should have been ignored by the config in pyrpoject.toml

Any ideas what I'm doing wrong here?

@peternewman peternewman added question packaging packaging related issue labels Oct 12, 2022
@peternewman
Copy link
Collaborator

Any ideas what I'm doing wrong here?

Just being impatient! 😄

As you'll see from my PR it works fine if you either install from git, or will do if you wait for a new release:
https://github.com/peternewman/codespell-pyproject-issue/actions/runs/3231297840/jobs/5290670231

@banesullivan
Copy link
Contributor Author

welp 🤦‍♂️ I did not realize this was a pre-release feature. Any idea when the next release might land?

Thanks!

@peternewman
Copy link
Collaborator

@larsoner normally does those because I'm terrible at actually doing it! 😄

@larsoner
Copy link
Member

After a little bit of iteration in master and cutting https://github.com/codespell-project/codespell/releases/tag/v2.2.2, we have https://pypi.org/project/codespell/2.2.2/#files

@banesullivan
Copy link
Contributor Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging packaging related issue question
Projects
None yet
Development

No branches or pull requests

3 participants