Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Also use Coursier in Bootstrap Launcher #128

Closed
hlxid opened this issue Aug 27, 2019 · 1 comment
Closed

Also use Coursier in Bootstrap Launcher #128

hlxid opened this issue Aug 27, 2019 · 1 comment
Assignees
@hlxid
Labels
enhancement New feature or request minor Quick to implement
Milestone
pre-alpha 3

Comments

@hlxid
Copy link
Member

hlxid commented Aug 27, 2019

Description

I would like to also reuse the PomInclusionPlugin that was created for #105 to include all required dependencies that the framework required inside the jar and also use coursier to download them in the bootstrap launcher. Beside of the advantage of code reuse this has also the advantage of dependency sharing between installations of chatoverflow and for all sbt >= 1.3.0 projects (whenever it gets released) and we also get some nice-to-have features like checksum verification of the jars for free.

However this means that dependency resolution is going to happen at runtime, instead of build-time like it is currently. Is everyone fine with that?

References

The PomInclusionPlugin was added in #113.
@hlxid hlxid added enhancement New feature or request minor Quick to implement labels Aug 27, 2019
@hlxid hlxid self-assigned this Aug 27, 2019
@hlxid hlxid added this to the pre-alpha 3 milestone Aug 27, 2019
@hlxid
Copy link
Member Author

hlxid commented Aug 30, 2019

Implemented in aa74e60

@hlxid hlxid closed this as completed Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hlxid hlxid

Labels
enhancement New feature or request minor Quick to implement
Projects
None yet
Milestone
pre-alpha 3
Development

No branches or pull requests
1 participant
@hlxid