-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Config helper #1071
Comments
first implementation done i just copy the getClassname function from BaseService, maybe we should move this function to the filelocator ? another thing is, we should store instances only by class name to avoid storing two instances for name and namspace + name |
Sorry for the delay - was on vacation.
Good idea.
sounds good |
np, me too^^ |
That service hasn't been tweaked to our specific requirements yet. It's just something we're trying out. We don't request changes or block diffs based on that report, so nothing to worry about. I'll take a look at the PR later today. Thanks. |
Inspired by #1070:
CodeIgniter\Config\Config
class with one public static method:get()
. This takes a class name and returns an instance of the class.false
, just like the Services class.Config\App
) it will simply try to instantiate/cache and return.App
), it will attempt to discover the class similar to way the Services class does, though don't discover and preload all of them, just as requested.config()
that is just a slightly nicer way of callingCodeIgniter\Config\Config::get()
.The text was updated successfully, but these errors were encountered: