From ca47f1fbdab88ed92ead0ba9e9f7234ca1224947 Mon Sep 17 00:00:00 2001 From: AdmiringWorm Date: Wed, 10 Jun 2020 13:23:32 +0200 Subject: [PATCH] (GH-71) Removed manual separator property on files argument By setting this property to a space character this introduced problems if the paths of the filse contained spaces. The commandline parser library we use already handles spaces in file paths without this and allows for multiple files paths to be specified with a space between them as long as each file path is correctly double quoted (must be double quoted to handle spaces). fixes #71 --- Source/Codecov/Program/CommandLineOptions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Codecov/Program/CommandLineOptions.cs b/Source/Codecov/Program/CommandLineOptions.cs index e33646b..b1cd694 100644 --- a/Source/Codecov/Program/CommandLineOptions.cs +++ b/Source/Codecov/Program/CommandLineOptions.cs @@ -62,7 +62,7 @@ public class CommandLineOptions : IVersionControlSystemOptions, ICoverageOptions /// A value specifing the enviornment variables to be included with this build. (1) /// CODECOV_ENV=VAR1,VAR2. (2) -e VAR1 VAR2. /// - [Option('e', "env", Separator = ' ', HelpText = "Specify enviornment variables to be included with this build. (1) CODECOV_ENV=VAR1,VAR2. (2) -e VAR1 VAR2.")] + [Option('e', "env", HelpText = "Specify enviornment variables to be included with this build. (1) CODECOV_ENV=VAR1,VAR2. (2) -e VAR1 VAR2.")] public IEnumerable Envs { get; set; } /// @@ -80,7 +80,7 @@ public class CommandLineOptions : IVersionControlSystemOptions, ICoverageOptions /// A value specifing the target file(s) to upload. (1) -f 'path/to/file'. Only upload this /// file. (2) -f 'path/to/file1 path/to/file2'. Only upload these files. /// - [Option('f', "file", Separator = ' ', HelpText = "Target file(s) to upload. (1) -f 'path/to/file'. Only upload this file. (2) -f 'path/to/file1 path/to/file2'. Only upload these files.")] + [Option('f', "file", HelpText = "Target file(s) to upload.\n(1) -f \"path/to/file\". Only upload this file.\n(2) -f \"path/to/file1\" \"path/to/file2\". Only upload these files.\nNOTE: Make sure to double quote paths if they contain spaces!")] public IEnumerable Files { get; set; } ///