Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdbStatResponse is not (sufficiently) pub #57

Closed
evanrichter opened this issue Nov 15, 2024 · 4 comments · Fixed by #59
Closed

AdbStatResponse is not (sufficiently) pub #57

evanrichter opened this issue Nov 15, 2024 · 4 comments · Fixed by #59

Comments

@evanrichter
Copy link

Hi, thanks for the awesome crate! It's working wonderfully to automate tests with hardware over adb.

I would like to implement ADBDeviceExt for an enum of either ADBUsbDevice or ADBServerDevice, so I can interact with a device using either protocol, but it's not possible for 3rd parties to impl ADBDeviceExt because AdbStatResponse is not reachable through public modules or a pub use export.

@cocool97
Copy link
Owner

Thanks for the issue, can you confirm that AdbStatResponse is the only struct with bad visibility?

@evanrichter
Copy link
Author

Yep, that's the only one

You can tell quickly by looking at the docs for ADBDeviceExt and noticing that AdbStatResponse is the only type or generic that isn't clickable

@cocool97
Copy link
Owner

Fix available in v2.0.4 !

@evanrichter
Copy link
Author

🔥 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants