-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circleci/ui: PhantomJS times out while running karma tests #9052
Comments
I don't think the issue is with PhantomJS itself, but rather that the tests just never ran. Based on comments in the following issues I'm going to increase the karma timeout. karma-runner/karma-phantomjs-launcher#126 There's also some discussion of PhantomJS running out of memory if this issue reoccurs. |
Please don't increase the timeout. There's no evidence here to indicate that it would have worked with a higher timeout. Something got wedged and died, I'm not sure it's worth investigating further just yet. |
In that case, should we close the issue for now? |
I'll leave it up to you and @knz. It might be good to keep it open to avoid duplicates if this does become more common. |
As another datapoint, setting |
(I haven't encountered the issue again after that original occurrence. I don't feel strongly either way. Perhaps we should leave the issue open until 1.0 is released and then we can close all issues we could not reproduce during pre-1.0 cleanups) |
I'm fine leaving open for now. It's possible that if we add more UI tests this will occur more frequently. |
Closing as stale. |
Found in https://circleci.com/gh/cockroachdb/cockroach/22185:
The text was updated successfully, but these errors were encountered: