Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci/ui: PhantomJS times out while running karma tests #9052

Closed
knz opened this issue Sep 1, 2016 · 8 comments
Closed

circleci/ui: PhantomJS times out while running karma tests #9052

knz opened this issue Sep 1, 2016 · 8 comments
Labels
C-test-failure Broken test (automatically or manually discovered).

Comments

@knz
Copy link
Contributor

knz commented Sep 1, 2016

Found in https://circleci.com/gh/cockroachdb/cockroach/22185:

> node install.js
PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
[...]
karma start

01 09 2016 22:01:30.650:INFO [karma]: Karma v1.2.0 server started at http://localhost:9876/

01 09 2016 22:01:30.653:INFO [launcher]: Launching browser PhantomJS with unlimited concurrency

01 09 2016 22:01:30.671:INFO [launcher]: Starting browser PhantomJS

01 09 2016 22:01:36.057:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]: Connected on socket /#7dLRFSZKJneYrWd3AAAA with id 20944495

01 09 2016 22:01:36.175:WARN [web-server]: 404: /base/jspm_packages/system-polyfills.js

PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'TypeScript', '[Warning]', 'http://localhost:9876/base/typings/modules/chai/index.d.ts -> global could not be resolved'

01 09 2016 22:01:49.703:WARN [PhantomJS 2.1.1 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.

PhantomJS 2.1.1 (Linux 0.0.0) ERROR

  Disconnected, because no message in 10000 ms.

Makefile:70: recipe for target 'test' failed
make: *** [test] Error 1
ui/ui.go:21: running "make": exit status 2
@knz knz added the C-test-failure Broken test (automatically or manually discovered). label Sep 1, 2016
@knz knz changed the title circleci: error while installing node.js due to failed PhantomJS server circleci/ui: error while installing node.js due to failed PhantomJS server Sep 1, 2016
@maxlang maxlang self-assigned this Sep 7, 2016
@maxlang
Copy link
Contributor

maxlang commented Sep 7, 2016

I don't think the issue is with PhantomJS itself, but rather that the tests just never ran.

Based on comments in the following issues I'm going to increase the karma timeout.

karma-runner/karma-phantomjs-launcher#126
karma-runner/karma#598

There's also some discussion of PhantomJS running out of memory if this issue reoccurs.
http://stackoverflow.com/questions/24119506/karma-jasmine-times-out-without-running-tests

@tamird
Copy link
Contributor

tamird commented Sep 7, 2016

Please don't increase the timeout. There's no evidence here to indicate that it would have worked with a higher timeout.

Something got wedged and died, I'm not sure it's worth investigating further just yet.

@maxlang
Copy link
Contributor

maxlang commented Sep 7, 2016

In that case, should we close the issue for now?

@tamird
Copy link
Contributor

tamird commented Sep 7, 2016

I'll leave it up to you and @knz. It might be good to keep it open to avoid duplicates if this does become more common.

@maxlang maxlang changed the title circleci/ui: error while installing node.js due to failed PhantomJS server circleci/ui: PhantomJS times out while running karma tests Sep 7, 2016
@maxlang
Copy link
Contributor

maxlang commented Sep 7, 2016

As another datapoint, setting browserNoActivityTimeout to 2s (default is 10s) caused the tests to fail for me locally, but they succeeded at 3s.

@knz
Copy link
Contributor Author

knz commented Sep 7, 2016

(I haven't encountered the issue again after that original occurrence. I don't feel strongly either way. Perhaps we should leave the issue open until 1.0 is released and then we can close all issues we could not reproduce during pre-1.0 cleanups)

@maxlang
Copy link
Contributor

maxlang commented Sep 7, 2016

I'm fine leaving open for now. It's possible that if we add more UI tests this will occur more frequently.

@maxlang maxlang removed their assignment Sep 9, 2016
@tamird
Copy link
Contributor

tamird commented Oct 4, 2016

Closing as stale.

@tamird tamird closed this as completed Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Development

No branches or pull requests

3 participants