From dfc060022bda12f4b01b424a98d33e0423ca2adb Mon Sep 17 00:00:00 2001 From: Ben Stein Date: Mon, 9 Oct 2023 15:14:05 -0400 Subject: [PATCH 1/2] Add logging for challenge sync at the info level. --- src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs b/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs index 8ee7ae09..7f098a2a 100644 --- a/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs +++ b/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs @@ -81,6 +81,7 @@ public async Task SyncExpired(CancellationToken cancellationToken) .Where(c => c.LastSyncTime < c.Player.SessionEnd && c.Player.SessionEnd < now) .ToArrayAsync(cancellationToken); + _logger.LogInformation($"Syncing data for {challenges.Length} expired challenges..."); foreach (var challenge in challenges) { try From 7ad36d02fabe76a48a32b3a35dafb4f8ace0fe23 Mon Sep 17 00:00:00 2001 From: Ben Stein Date: Mon, 9 Oct 2023 15:15:20 -0400 Subject: [PATCH 2/2] Remove unused validator. --- src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs | 1 - src/Gameboard.Api/Features/Challenge/ChallengeValidator.cs | 5 ----- src/Gameboard.Api/Features/Player/PlayerValidator.cs | 2 +- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs b/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs index 7f098a2a..8ee7ae09 100644 --- a/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs +++ b/src/Gameboard.Api/Features/Challenge/ChallengeSyncService.cs @@ -81,7 +81,6 @@ public async Task SyncExpired(CancellationToken cancellationToken) .Where(c => c.LastSyncTime < c.Player.SessionEnd && c.Player.SessionEnd < now) .ToArrayAsync(cancellationToken); - _logger.LogInformation($"Syncing data for {challenges.Length} expired challenges..."); foreach (var challenge in challenges) { try diff --git a/src/Gameboard.Api/Features/Challenge/ChallengeValidator.cs b/src/Gameboard.Api/Features/Challenge/ChallengeValidator.cs index a4943139..fe5d7e84 100644 --- a/src/Gameboard.Api/Features/Challenge/ChallengeValidator.cs +++ b/src/Gameboard.Api/Features/Challenge/ChallengeValidator.cs @@ -35,11 +35,6 @@ public Task Validate(object model) throw new System.NotImplementedException(); } - private Task _validate(PlayerDataFilter model) - { - return Task.CompletedTask; - } - private async Task _validate(Entity model) { if ((await _store.Exists(model.Id)).Equals(false)) diff --git a/src/Gameboard.Api/Features/Player/PlayerValidator.cs b/src/Gameboard.Api/Features/Player/PlayerValidator.cs index 56300db8..5b074503 100644 --- a/src/Gameboard.Api/Features/Player/PlayerValidator.cs +++ b/src/Gameboard.Api/Features/Player/PlayerValidator.cs @@ -166,7 +166,7 @@ private async Task _validate(TeamAdvancement model) public async Task _validate(SessionResetCommandArgs args) { - if (!(await Exists(args.PlayerId))) + if (!await Exists(args.PlayerId)) throw new ResourceNotFound(args.PlayerId); if (IsActingAsAdmin(args.ActingUser))