Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty delimiter does not work with TF 0.12 #77

Closed
jhosteny opened this issue Jul 17, 2019 · 2 comments · Fixed by #99
Closed

Empty delimiter does not work with TF 0.12 #77

jhosteny opened this issue Jul 17, 2019 · 2 comments · Fixed by #99
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jhosteny
Copy link

The delimiter is calculated with the coalesce function, which considers and empty string and a null string as the same thing. This prevents the delimiter from being set as "", which is useful for certain resources. For example, Azure storage account container names can only contain lowercase letters and numbers.

I'm not sure of the best way to fix this, other than add a flag that says to not use the delimiter. The regex is applied before the delimiter is added. I could submit a PR for a new flag if that would be acceptable.

@tyler-iherb
Copy link

i cant remove delimiter, please add this option to not use

@osterman
Copy link
Member

Hrmm... sure, if you want to submit a PR for this, we'll accept it.

@osterman osterman added enhancement New feature or request help wanted Extra attention is needed labels Aug 10, 2020
@Nuru Nuru closed this as completed in #99 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants