Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Module Sources in Examples #34

Closed
osterman opened this issue Jul 27, 2018 · 1 comment
Closed

Fix Module Sources in Examples #34

osterman opened this issue Jul 27, 2018 · 1 comment
Assignees
@vadim-gleif
Labels
bug 🐛 An issue with the system

Comments

@osterman
Copy link
Member

what

  • Examples use ../../ module source location which is confusing

why

  • Should use canonical github URLs
@osterman osterman added the bug 🐛 An issue with the system label Jul 27, 2018
@osterman osterman assigned vadim-gleif and unassigned aknysh Aug 7, 2018
@aknysh
Copy link
Member

aknysh commented Aug 24, 2018

Addressed in #36

@aknysh aknysh closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadim-gleif vadim-gleif

Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@osterman @aknysh @vadim-gleif