Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple lines in before_cluster_joining_userdata and after_cluster_joining_userdata? #183

Closed
kevincantu opened this issue May 30, 2024 · 0 comments · Fixed by #186
Labels
bug 🐛 An issue with the system

Comments

@kevincantu
Copy link

Describe the Bug

When I specify multiple items in the before_cluster_joining_userdata list, I get an error on plan:

│ You may not specify more than one `before_cluster_joining_userdata`.

There's actually a test here which limits this list to one item!!

variable "before_cluster_joining_userdata" {
  type        = list(string)
  default     = []
  description = "Additional `bash` commands to execute on each worker node before joining the EKS cluster (before executing the `bootstrap.sh` script). For more info, see https://kubedex.com/90-days-of-aws-eks-in-production"
  validation {
    condition = (
      length(var.before_cluster_joining_userdata) < 2
    )
    error_message = "You may not specify more than one `before_cluster_joining_userdata`."
  }
}

Can we support a list, or update the documentation on this and after_cluster_joining_userdata?

Expected Behavior

The docs say:

before_cluster_joining_userdata list(string)
Description: Additional bash commands to execute on each worker node before joining the EKS cluster (before executing > the bootstrap.sh script). For more info, see https://kubedex.com/90-days-of-aws-eks-in-production
Default: []

Steps to Reproduce

module "nodegroups" {
  source = "git::https://github.com/cloudposse/terraform-aws-eks-node-group.git//?ref=6ccf1a9e30101540d479bbc9e185513476fff17a"
  ...
  before_cluster_joining_userdata = [
    "echo one",
    "echo two",
   ...

### Screenshots

_No response_

### Environment

_No response_

### Additional Context

_No response_
@kevincantu kevincantu added the bug 🐛 An issue with the system label May 30, 2024
@Nuru Nuru closed this as completed in #186 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant