CloudinaryField blank=True not working in 1.5.0: object of type 'NoneType' has no len() #81

michaelgodshall · 2016-11-19T00:07:24Z

Today I installed the latest 1.5.0 release in my Django 1.10 project, but CloudinaryField doesn't seem to be working when blank=True:

image = CloudinaryField('image', blank=True)

I'm getting the following error when accessing the object in the admin:

object of type 'NoneType' has no len()

I believe the error is connected to the from_db_value and to_python definitions in cloudinary/models.py. They are checking if value is None, but they should be checking if not value. CloudinaryField is a CharField type and the value of a blank CharField is an empty string, not None.

I am able to fix the error with the above changes, which look like this:

def from_db_value(self, value, expression, connection, context):
    if not value:
        return value
    return self.parse_cloudinary_resource(value)

def to_python(self, value):
    if isinstance(value, CloudinaryResource):
        return value
    elif isinstance(value, UploadedFile):
        return value
    elif not value:
        return value
    else:
        return self.parse_cloudinary_resource(value)

The previous version of cloudinary implemented this correctly, so I'm not sure why this was changed in 1.5.0.

The text was updated successfully, but these errors were encountered:

roeeba · 2016-11-20T14:46:09Z

Hi @godshall , Can you please share with us the following details?

Full error message and stacktrace.
Which python version are you using?

Thanks

michaelgodshall · 2016-11-21T20:43:00Z

Environment:

Request Method: GET
Request URL: //localhost:3000/admin/actions/action/3/change/

Django Version: 1.10.2
Python Version: 3.5.0
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.messages',
'django.contrib.staticfiles',
'django_extensions',
'rest_framework',
'my_site',
'actions']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
'whitenoise.middleware.WhiteNoiseMiddleware',
'django.middleware.gzip.GZipMiddleware',
'debreach.middleware.RandomCommentMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware']

Template error:
In template /Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/contrib/admin/templates/admin/change_form.html, error at line 33
object of type 'NoneType' has no len() 23 : {% endblock %}
24 : {% endif %}
25 :
26 : {% block content %}

27 : {% block object-tools %}
28 : {% if change %}{% if not is_popup %}
29 :

32 : {% url opts|admin_urlname:'history' original.pk|admin_urlquote as history_url %}
33 : {% trans "History" %}
34 :

{% trans "View on site" %}

38 : {% endif %}{% endif %}
39 : {% endblock %}
40 : <form {% if has_file_field %}enctype="multipart/form-data" {% endif %}action="{{ form_url }}" method="post" id="{{ opts.model_name }}_form" novalidate>{% csrf_token %}{% block form_top %}{% endblock %}
41 :

42 : {% if is_popup %}{% endif %}
43 : {% if to_field %}{% endif %}

Traceback:

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
39. response = get_response(request)

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
217. response = self.process_exception_by_middleware(e, request)

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
215. response = response.render()

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/template/response.py" in render
109. self.content = self.rendered_content

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/template/response.py" in rendered_content
86. content = template.render(context, self._request)

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/template/backends/django.py" in render
66. return self.template.render(context)

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/template/base.py" in render
208. return self._render(context)

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/test/utils.py" in instrumented_test_render
94. return self.nodelist.render(context)

File "/Users/me/.virtualenvs/my-site/lib/python3.5/site-packages/django/template/base.py" in render
994. bit = node.render_annotated(context)