cf update-buildpack takes negative value for position and gives success result

[asifdxtreme]

htipl@cf1:~/workspace/bosh-lite$ cf buildpacks
Getting buildpacks...

buildpack          position   enabled   locked   filename
java_buildpack     1          true      false    java-buildpack-v2.4.zip
ruby_buildpack     2          true      false    ruby_buildpack-offline-v1.1.0.zip
java_off           3          true      false    java-buildpack-offline-647c0bd.zip
nodejs_buildpack   4          true      false    nodejs_buildpack-offline-v1.0.1.zip
go_buildpack       5          true      false    go_buildpack-offline-v1.0.1.zip
python_buildpack   6          true      false    python_buildpack-offline-v1.0.1.zip
php_buildpack      7          true      false    php_buildpack-offline-v1.0.1.zip
htipl@cf1:~/workspace/bosh-lite$ cf update-buildpack java_off -i -6
Updating buildpack java_off...
OK
htipl@cf1:~/workspace/bosh-lite$ cf buildpacks
Getting buildpacks...

buildpack          position   enabled   locked   filename
java_off           1          true      false    java-buildpack-offline-647c0bd.zip
java_buildpack     2          true      false    java-buildpack-v2.4.zip
ruby_buildpack     3          true      false    ruby_buildpack-offline-v1.1.0.zip
nodejs_buildpack   4          true      false    nodejs_buildpack-offline-v1.0.1.zip
go_buildpack       5          true      false    go_buildpack-offline-v1.0.1.zip
python_buildpack   6          true      false    python_buildpack-offline-v1.0.1.zip
php_buildpack      7          true      false    php_buildpack-offline-v1.0.1.zip

cf update-buildpack java_off -i -6

cf update-buildpack takes the -i[POSITION] parameter as (-6) and gives successful result.

Expected Behaviour : - It should throw an error as an invalid position

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/82828946.

[asifdxtreme]

@goehmen

I think this issue should be handled by proper validation in the code so that cli can detect the negative input for POSITION and can warn the user about the invalid position.

[goehmen]

Hi Asif:

Yes. The CLI team debated this last night at some length. We came to the conclusion that this is not a bug and that as a feature, it is something that members of the user community could be leveraging today. Thus rather than treating it as a bug and removing the ability to pass in any non-positive integer and expecting to have the buildpack assume the #1 position, we are going to simply word the messaging around this more strongly .

That story is currently in the pipeline so I'm going to close this issue. please reopen if the need arises.

[asifdxtreme]

@goehmen thanks for the clear explanation, I got your point