Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further questionable words in randomly generated routes #1261

Closed
mkretz opened this issue Nov 1, 2017 · 4 comments
Closed

Further questionable words in randomly generated routes #1261

mkretz opened this issue Nov 1, 2017 · 4 comments
Labels

Comments

@mkretz
Copy link

mkretz commented Nov 1, 2017

Command

cf push example-app -d shared-domain.example.com --random-route

What occurred

An app received the route static-app-nonarithmetic-paedophilia.scapp.io

What you expected to occur

No problematic words occur in randomly generated routes

Follow-up to PR #217. I checked nouns.txt and adjectives.txt. It is just a matter of removing this word (and related ones) from these two files. Do you agree that I create a pull request?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152465786

The labels on this github issue will be updated when the story is started.

@dkoper
Copy link

dkoper commented Nov 1, 2017

That would be great, thanks!

@mkretz
Copy link
Author

mkretz commented Nov 1, 2017

Thanks! Created PR #1262.

@dkoper
Copy link

dkoper commented Nov 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants