From a359195fb555ed686760f9528dbc97c63e690f51 Mon Sep 17 00:00:00 2001 From: Chitoku Date: Fri, 19 Jan 2024 03:03:56 +0900 Subject: [PATCH] Ensure response body is always closed in CloudControllerConnection (#2425) --- api/cloudcontroller/cloud_controller_connection.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/cloudcontroller/cloud_controller_connection.go b/api/cloudcontroller/cloud_controller_connection.go index 525f49a5f1f..7eb9c8d8b34 100644 --- a/api/cloudcontroller/cloud_controller_connection.go +++ b/api/cloudcontroller/cloud_controller_connection.go @@ -55,6 +55,7 @@ func (connection *CloudControllerConnection) Make(request *Request, passedRespon if err != nil { return connection.processRequestErrors(request.Request, err) } + defer response.Body.Close() return connection.populateResponse(response, passedResponse) } @@ -64,7 +65,6 @@ func (*CloudControllerConnection) handleStatusCodes(response *http.Response, pas passedResponse.RawResponse = []byte("{}") } else { rawBytes, err := ioutil.ReadAll(response.Body) - defer response.Body.Close() if err != nil { return err }