Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wildcard is not allowed under application manifest for routes section #399

Closed
prashantgnet opened this issue Feb 9, 2018 · 11 comments
Closed

Comments

@prashantgnet
Copy link

prashantgnet commented Feb 9, 2018

As domain and host are going to be deprecated, I am trying to use routes property for application manifest for "*" i.e. wildcard host-name to support multi-tenancy but it gives me following error message

cf push -f manifest.yml
Pushing from manifest to org o / space o93 as admin...
Using manifest file manifest.yml
The route '*.o93r2.testdoamin.com/tenant' is not a properly formed URL
FAILED 

Following is my application manifest file, I have tried multiple options like defining http, www, double quotes but no luck

---
applications:
- name: test-tenant
  memory: 2048M
  disk_quota: 1024M
  instances: 1
  timeout: 300
  health-check-type: http
  health-check-http-endpoint: /tenant/commons/health
  path: ./jars/tenant-service.jar
  buildpack: java_buildpack
  routes:
  - route: '*.o93r2.testdomain.com/tenant'
  - route: '*.os93r2.testdomain.com/tenant'
  env:
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155060885

The labels on this github issue will be updated when the story is started.

@XenoPhex
Copy link

XenoPhex commented Feb 9, 2018

Looks like the way the CLI is parsing the route in the YAML file is incorrect. For now, a work around is to create and map the routes by hand (via the cf map-route) command. We'll try and get the fix in shortly!

@XenoPhex
Copy link

XenoPhex commented Feb 12, 2018

Fixed in the following commit: cloudfoundry/cli@70e297c

@prashantgnet
Copy link
Author

prashantgnet commented Feb 15, 2018

Thanks for quickly fixing the issue, I would like to know which CLI version will contain this fix?

Thanks,
Prashant

@jbpivotal
Copy link

@prashantgnet This fix will be in cf CLI v6.35.0, which is the next release and almost ready to ship.

@prashantgnet
Copy link
Author

I know my queries are not related to mentioned issue but I don't want to raise new issue.

  1. When domain and host are going to be deprecated and replace by route property?
  2. Is the removal of domain and host just from the cf CLI or is it a change in the cloud controller itself?

Thanks,
Prashant

@prashantgnet
Copy link
Author

Verified and working fine using CF CLI 6.35

Thanks,
Prashant

@jbpivotal
Copy link

@prashantgnet Thanks for confirming.

@dsabeti
Copy link
Contributor

dsabeti commented Mar 13, 2018

Great!, I'll go ahead and close this issue, but feel free to re-open if you need more help.

@hoegaarden
Copy link

We still see the same issue with cf version 7.2.0+be4a5ce2b.2020-12-10.

We've

  • pushed an app manually
  • manually bound wildcard routes to the app
  • and then used cf create-app-manifest to get the manifest

Applying that manifest then resulted in an error, so we need to do the route mapping out of band for now.

---
applications:
- name: error-page
  stack: cflinuxfs3
  routes:
  - route: "*.apps.XXX.com"
  - route: "*.apps.domain2.XXX.com"
  - route: "*.apps.domain1.XXX.com"
  no-route: true
  buildpacks:
  - nginx_buildpack
  processes:
  - type: web
    instances: 3
    memory: 16M
    disk_quota: 100M
    health-check-type: port

@XenoPhex
Copy link

@hoegaarden You'd want to redirect this issue to the Cloud Controller team as manifest handling is done by that team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants