Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: New Hono project from C3 creates wrangler.toml and wrangler.json #7905

Open
irvinebroque opened this issue Jan 25, 2025 · 3 comments · May be fixed by #7922
Open

🐛 BUG: New Hono project from C3 creates wrangler.toml and wrangler.json #7905

irvinebroque opened this issue Jan 25, 2025 · 3 comments · May be fixed by #7922
Labels
bug Something that isn't working

Comments

@irvinebroque
Copy link
Contributor

Which Cloudflare product(s) does this pertain to?

C3 (npm create cloudflare), Wrangler

What versions are you using?

latest

What operating system and version are you using?

latest

Please provide a link to a minimal reproduction

https://x.com/thinanchor/status/1881410770208272729

Describe the Bug

  1. npm create cloudflare@latest
  2. choose hono
  3. observe that the project has both a wrangler.json and a wrangler.toml
➜  src cd hono
➜  hono ls
README.md                 package.json              worker-configuration.d.ts
node_modules              src                       wrangler.json
package-lock.json         tsconfig.json             wrangler.toml

Beyond the obvious fix — I think when we see that there is both a wrangler.json and a wrangler.toml present — we should consdier:

  1. warn people loudly
  2. say when you run wrangler dev which configuration file is being used

Please provide any relevant error logs

No response

@irvinebroque irvinebroque added the bug Something that isn't working label Jan 25, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jan 25, 2025
@irvinebroque
Copy link
Contributor Author

refs #7676 or #7774 ?

@irvinebroque
Copy link
Contributor Author

think maybe because hono is a framework but also a worker, while default for other frameworks are to target pages?

@yusukebe
Copy link
Contributor

Hey @irvinebroque

The starter template in Hono now uses wrangler.toml, but anyway, using wrangler.json is good if the C3 starts using wrangler.json. We'll work on making the template using wrangler.json instead of wrangler.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
Status: Backlog
2 participants