-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update esbuild
to latest version (wrangler dev does not work on Android)
#1732
Comments
Hey @Resonious, don't suppose you have any tips/guides for setting up an android to replicate this bug? |
Invoking Miniflare directly appears to work fine, so I'm guessing there's something about the way Wrangler forks Miniflare that Android doesn't like. |
Quick update! I have some free time today so I'm looking into this. So far I've traced this back to the esbuild watcher. The watcher seems to be constantly reporting changes. If I remove the bundle from the React effect that restarts the server, it "works" as long as I toggle local mode or do something else to kick off the initial build/run. I'm going to see if I can figure out whether this is actually an esbuild bug on Android or if there's some config we can pass to calm it down. |
This seems related but it's supposedly fixed already: evanw/esbuild#1113 |
Yeah okay sorry for the spam. I was able to reproduce this with just esbuild: I opened an issue on esbuild itself: evanw/esbuild#2640 - once that's fixed, all we need to do is update the esbuild dependency in Wrangler. |
This problem seems to still exist in the latest release (2.4.4) |
esbuild
to latest version (wrangler dev does not work on Android)
What version of
Wrangler
are you using?2.0.27
What operating system are you using?
Android
Describe the Bug
UPDATE: this is actually an esbuild bug: evanw/esbuild#2640. Therefore, we can probably fix this either by not using esbuild's watch feature or by fixing the bug in esbuild itself.
I realize I may be a freak for developing on Android, but alas I do and I'm unable to perform the quick Workers example on the readme.
The
![SmartSelect_20220825-211751_Termux](https://user-images.githubusercontent.com/2793160/186665681-43806105-e07b-411e-a54a-35c0fb722e64.jpg)
npx wrangler dev index.js
command does run "successfully", but it spam reloads and the server is inaccessible.Pretty much the same result whether or not I pass
--local
. A basic Express server runs fine on this device so I don't think there's anything wrong with my environment.The text was updated successfully, but these errors were encountered: