Don't move point when clearing or highlighting test results

[r0man]

When running tests with cider-test failing tests are highlighted in the source
files, or if tests are passing again previous highlights are cleared. The code
that does this is using the cider-find-var function to find the buffer for a
vars under test and then does it's job.

cider-find-var used to move point to the line at which the var was found. This
is a problematic side effect, because code using cider-find-var to find the
buffer can't use save-excursion because it doesn't know which buffer to safe
beforehand.

This PR removes the goto-line in cider-find-var and returns just the buffer
without any side effect. The cider-company-location uses similar code as
cider-find-var but with save-excursion wrapped around it.

[bbatsov]

Seems to me that your change will affect the behavior of C-..

[r0man]

cider-jump-to-var seems to still work for me. What do you mean exactly?

[bbatsov]

There's already a Bugs fixed section beneath Changes.

[r0man]

Fixed the duplicate "Bugs fixed" section and rebased.

[bbatsov]

Ah, the name cider-find-var confused me; someone should change this to cider-find-var-buffer or something similar... Guess this was done solely for company's benefit then.

👍 from me, but let's wait to hear from @jeffvalk as well because he recently refactored this code.

[bbatsov]

@jeffvalk Ping :-)

[jeffvalk]

Pardon my tardiness on this! Yes, this change makes sense to me. @r0man Would you update this PR to apply against HEAD?

I also agree with @bbatsov that the name cider-find-var should be changed to reflect the revised behavior. Since it would now essentially mimic cider-find-file, perhaps cider-find-var-file makes sense.

[r0man]

@jeffvalk & @bbatsov I rebased this on master

[bbatsov]

👍