-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #493] Rotate nREPL connection handles no nREPL connection. #494
Conversation
Perhaps at some stage:
Could be pulled out into a macro as it's used frequently. |
@@ -28,6 +28,7 @@ visually distinctive from `cider-repl-output-face` (used for STDOUT output). | |||
|
|||
### Bugs fixed | |||
|
|||
* [#493](https://github.com/clojure-emacs/cider/issues/493) Fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me you forgot something here :-)
I don't think a macro is required. A simple function like this should do: (defun cider-ensure-connected ()
(unless (cider-connected-p)
(error "No active nREPL connection")))
|
The changelog I'll fix :-) I'll use the fn you suggest and use it in the other locations where |
Changes made. I could edit to commit msg to read "and introducing cider-ensure-connected" if you want. |
Yep, that'd be nice. Alternatively you can have this split into two commits, as they are unrelated. |
…troduce cider-ensure-connected.
I changed the commit msg :-) |
[Fix #493] Rotate nREPL connection handles no nREPL connection.
Thanks! |
Fixes #493